Skip to content

[Test] Conditionalize KVOKeyPaths tests that only work with Swift 5.1 #24836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2019

Conversation

bob-wilson
Copy link
Contributor

Some of the tests in KVOKeyPaths.swift check problems that were not fixed
until Swift 5.1 so they are not expected to pass when running with the
5.0 libraries.

rdar://problem/50173830

@bob-wilson bob-wilson requested a review from millenomi May 16, 2019 18:25
@bob-wilson
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 14f79ef5f43801252e39dca6bbf3c01da7a48111

Some of the tests in KVOKeyPaths.swift check problems that were not fixed
until Swift 5.1 so they are not expected to pass when running with the
5.0 libraries.

rdar://problem/50173830
@bob-wilson
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 14f79ef5f43801252e39dca6bbf3c01da7a48111

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 14f79ef5f43801252e39dca6bbf3c01da7a48111

@bob-wilson
Copy link
Contributor Author

@swift-ci smoke test linux platform

@bob-wilson
Copy link
Contributor Author

@swift-ci smoke test linux platform

@bob-wilson
Copy link
Contributor Author

@swift-ci please test linux platform

@bob-wilson bob-wilson merged commit 2e12ac8 into swiftlang:master May 21, 2019
@bob-wilson bob-wilson deleted the rdar50173830 branch May 21, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants