Skip to content

[Test] Conditionalize KVOKeyPaths tests that only work with Swift 5.1 #24851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2019

Conversation

bob-wilson
Copy link
Contributor

Some of the tests in KVOKeyPaths.swift check problems that were not fixed
until Swift 5.1 so they are not expected to pass when running with the
5.0 libraries.

rdar://problem/50173830

Some of the tests in KVOKeyPaths.swift check problems that were not fixed
until Swift 5.1 so they are not expected to pass when running with the
5.0 libraries.

rdar://problem/50173830
@bob-wilson
Copy link
Contributor Author

Cherry-pick #24836 to the 5.1 branch

@bob-wilson
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - c0d3f16

@bob-wilson
Copy link
Contributor Author

@swift-ci smoke test linux platform

@bob-wilson
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - c0d3f16

@bob-wilson
Copy link
Contributor Author

@swift-ci please test linux platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - c0d3f16

@shahmishal
Copy link
Member

@swift-ci please test linux platform

@bob-wilson bob-wilson merged commit 47395e1 into swiftlang:swift-5.1-branch May 22, 2019
@bob-wilson bob-wilson deleted the rdar50173830-51 branch May 22, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants