Support unavailable and obsoleted attributes on extensions #24997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Members of an extension inherit the availability of the extension. This was previously supported for introduced and deprecated, but not unavailable and obsoleted. rdar://problem/50949936
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
This is worth a CHANGELOG entry. |
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
This change permits the use of unavailable types in unavailable signatures. It affects only usage of `available(*, unavailable)`. This fixes a compilation error in swift-corelibs-foundation/Foundation/ URLSession/URLSessionConfiguration.swift where an unavailable property was typed by an unavailable type.
xymus
force-pushed
the
extension-availability
branch
from
869d4b6 to
9b59ec5
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
slavapestov
approved these changes
May 29, 2019
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Members of an extension should inherit the availability of the extension. This was previously supported for
introducedanddeprecated, but notunavailableandobsoleted.