-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Accelerate] Declare availability where missing, remove where redundant #25776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Declarations lexically nested in a context with an @available declaration inherit the same.
@swift-ci test |
Build failed |
@stephentyrone In its current state this will conflict with your 9999 PR :( Feel free to merge that first if you like -- I already have a version of this based on that. |
@xymus, did you get in your change for availability on extensions to propagate to members? If not, this isn't safe to take yet either. |
@jrose-apple Is that a new issue? I think this has "always" worked:
|
(I can revert the last commit if we need to keep the attributes on the individual members, but then we'll also need to review the codebase to make sure we have them everywhere. I don't think even Accelerate declares |
Merging to fix the ABI issue of missing @available decls. I'll submit a cherry pick to 5.1 in a jiffy. |
Accelerate.vImage
,.vDSP
and.vForce
are introduced in macOS 10.15 / iOS 13, but they are currently declared without availability.@available
attributes to them and their extensions.@available
attributes from the ~500 entry points defined invImage
/vDSP
/vForce
extensions. (Their availability is now inherited from the top-level extension.)