-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[TF] Remove all TensorFlow tests. #25239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The TensorFlow module has been moved to [tensorflow/swift-apis](https://github.com/tensorflow/swift-apis), and all tests have been copied. Tests here are not updated against library changes, and are currently blocking updating the checkout hash for tensorflow/swift-apis for v0.4 toolchain builds. ```console Failing Tests (8): Swift(macosx-x86_64) :: TensorFlowRuntime/dataset_1.swift Swift(macosx-x86_64) :: TensorFlowRuntime/dynamic_attributes.swift Swift(macosx-x86_64) :: TensorFlowRuntime/dynamic_compilation_tensor_group.swift Swift(macosx-x86_64) :: TensorFlowRuntime/tensor_array_protocol.swift Swift(macosx-x86_64) :: TensorFlowRuntime/tensor_autodiff_runtime.swift Swift(macosx-x86_64) :: TensorFlowRuntime/tensor_group.swift Swift(macosx-x86_64) :: TensorFlowRuntime/tracer.swift Swift(macosx-x86_64) :: TensorFlowRuntime/tracer_tffunc.swift Expected Passes : 28 Expected Failures : 1 Unexpected Failures: 8 ``` This PR removes all TensorFlow tests and unblocks things. Note: - TensorFlow is being well-tested in tensorflow/swift-apis. Removing tests is okay. - The only existing test that's not being removed by this PR is `Sema/struct_key_path_iterable.swift`. It should not depend on TensorFlow, so we should update it soon.
@swift-ci please test tensorflow |
Dataset.map relies on the functionality tested by these tests:
What are the failures in these tests? |
They rely on the old
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 for unblocking swift-apis
.
Sounds good. I closed the new one as it duplicates https://bugs.swift.org/browse/TF-541, which already tracks migration of tests. |
The TensorFlow module has been moved to tensorflow/swift-apis, and all tests have been copied. Tests here are not updated against library changes, and are currently blocking updating the checkout hash for tensorflow/swift-apis for v0.4 toolchain builds.
This PR removes all TensorFlow tests and unblocks things.
Note:
Sema/struct_key_path_iterable.swift
. It should not depend on TensorFlow, so we should update it soon.