Split off StorageImplInfo from AccessorRecord #26235
Conversation
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
There was a problem hiding this comment.
It would be easier to review patches if you focused on one thing per PR instead of also throwing in a refactor of how we represent storage specifiers.
Please continue using a specifier enum on VarDecl instead of a boolean isLet; it's clearer in source and will allow minor extensions in this area (e.g. local shared/inout bindings) to avoid having to refactor it back.
The parts of the patch that are actually specific to the representation of StorageImplInfo in an AbstractStorageDecl seem reasonable.
We want to compute the former independently of the latter. It's only 16 bits so storing it inside the Decl is fine; it also allows us to eliminate the 'compact' representation where an AbstractStorageDecl without an accessor record is assumed to be stored.
slavapestov
force-pushed
the
accessor-refactoring
branch
from
3773ad5 to
454281b
Compare
|
@rjmccall Alright, I'm now using a new VarDecl::Introducer enum to distinguish |
|
apple/swift-lldb#1820 |
|
apple/swift-lldb#1820 |
|
Build failed |
|
apple/swift-lldb#1820 |
This is in service of creating a request to compute AbstractStorageDecl::getStorageImplInfo(). Should be NFC.