Use a request to compute AbstractStorageDecl::getImplInfo() #26282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
storage-impl-info-request
branch
from
39eda2a to
309bc5c
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
rjmccall
approved these changes
Jul 23, 2019
Some requests are implemented in lib/Sema/, even if they don't require a LazyResolver. Be sure to register their request functions in SourceKit so that these requests can be kicked off when needed.
Soon this will be performed lazily as part of a request.
This just moves the code from the parser into a request. Sema will still overwrite the ImplInfo field for lazy properties and property wrappers; refactoring that is next.
slavapestov
force-pushed
the
storage-impl-info-request
branch
from
309bc5c to
60e1dfe
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
Build failed |
|
@swift-ci Please test Linux |
|
@swift-ci Please smoke test macOS |
|
Build failed |
|
@swift-ci Please smoke test Linux |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the ImplInfo was first set by the parser, then in some cases later updated by the type checker. For example, a lazy property would start out as a stored property (
hasStored()returns true), then after type checking it was "lowered" to a computed property (hasStorage()returns false).The goal is to do the StorageImplInfo computation using a request so it is always up to date and correct, merging some code from the parser together with some code that previously ran as part of
maybeAddAccessorsToStorage().This PR gets us most of the way there --
maybeAddAccessorsToStorage()still updates the StorageImplInfo for lazy properties and property wrappers.Follow-up to #26235.