Skip to content

Fix the mid-level pass pipeline #26256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Fix the mid-level pass pipeline #26256

wants to merge 7 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 20, 2019

This is a pull request originally created by @atrick. However, this was made months ago and with the many changes that has gone on since, I figured I would put those changes in a PR.

Original PR: #22445

Don't inline array semantic calls before the mid-level pipeline.

Fix the mid-level pipeline restart mechanism.

Copy link
Collaborator

@theblixguy theblixguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contains commits unrelated to the original patch (one from #26122 for example). Also, seems like the merge was not committed correctly?

@xwu
Copy link
Collaborator

xwu commented Jul 21, 2019

As he noted in the original PR, @atrick put his PR on hold because of performance issues that need to be investigated. If you're interested in this progressing forward, you can ping him to see if he's ready to resume or if you can help, but it's not cool to claim his work for your own in a separate PR like this.

@ghost
Copy link
Author

ghost commented Jul 21, 2019

I gave him credit, because I want to see these performance improvements in swift. I understand why it is not cool, and I apologize if it came out that way; I will ask him about it.

@CodaFi
Copy link
Contributor

CodaFi commented Jul 21, 2019

A lot of these changes are purely stylistic and should probably be landed individually. Could you split them from this patch and submit them in chunks?

@ghost ghost closed this Jul 27, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants