Disable property wrapper composition. #26287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are ABI-affecting bugs with composition like SR-11138, so disable until those bugs can be fixed. rdar://problem/53428736
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
jrose-apple
reviewed
Jul 23, 2019
| if (result.size() > 1) { | ||
| ctx.Diags.diagnose(result[result.size() - 2]->getLocation(), | ||
| diag::property_wrapper_composition_not_implemented); | ||
| } |
There was a problem hiding this comment.
Nitpick: If you do this after the std::reverse below, you can avoid the weird "second-to-last" computation above, which confused me until I read the comment below.
jrose-apple
approved these changes
Jul 23, 2019
|
@swift-ci Please test |
rxwei
added a commit
to rxwei/swift
that referenced
this pull request
Aug 27, 2019
* Add derived conformances for the `EuclideanDifferentiable` protocol introduced in swiftlang#26287 when a conforming type satisfies `Differentiable` conformance synthesis requirements. ```swift struct Foo<T>: EuclideanDifferentiable where T.TangentVector == T { var x: T var y: T @noDerivative var z: Bool // The compiler synthesizes the following `EuclideanDifferentiable` requirement: // var vectorView: TangentVector { // return TangentVector(x: x, y: y) // } } ``` * Remove `vectorView`'s setter. This should not have been added to the protocol, for the same reason as [TF-208](https://bugs.swift.org/browse/TF-208). A projection (`vectorView`) of a subset of properties should reflect these properties joint mutability, which is impossible to express at the moment. Resolves [TF-777](https://bugs.swift.org/browse/TF-777).
dan-zheng
pushed a commit
that referenced
this pull request
Aug 27, 2019
#26867) Add derived conformances for the `EuclideanDifferentiable` protocol introduced in #26287 when a conforming type satisfies `Differentiable` conformance synthesis requirements. ```swift struct Foo<T>: EuclideanDifferentiable where T.TangentVector == T { var x: T var y: T @noDerivative var z: Bool // The compiler synthesizes the following `EuclideanDifferentiable` requirement: // var vectorView: TangentVector { // return TangentVector(x: x, y: y) // } } ``` Remove `vectorView`'s setter. This should not have been added to the protocol, for the same reason as [TF-208](https://bugs.swift.org/browse/TF-208). A projection (`vectorView`) of a subset of properties should reflect these properties joint mutability, which is impossible to express at the moment. Resolves [TF-777](https://bugs.swift.org/browse/TF-777).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are ABI-affecting bugs with composition like SR-11138, so disable until those bugs can be
fixed. rdar://problem/53428736