[AutoDiff] [stdlib] Derive conformances for 'EuclideanDifferentiable'. #26867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add derived conformances for the `EuclideanDifferentiable` protocol introduced in swiftlang#26287 when a conforming type satisfies `Differentiable` conformance synthesis requirements. ```swift struct Foo<T>: EuclideanDifferentiable where T.TangentVector == T { var x: T var y: T @noDerivative var z: Bool // The compiler synthesizes the following `EuclideanDifferentiable` requirement: // var vectorView: TangentVector { // return TangentVector(x: x, y: y) // } } ``` * Remove `vectorView`'s setter. This should not have been added to the protocol, for the same reason as [TF-208](https://bugs.swift.org/browse/TF-208). A projection (`vectorView`) of a subset of properties should reflect these properties joint mutability, which is impossible to express at the moment. Resolves [TF-777](https://bugs.swift.org/browse/TF-777).
rxwei
force-pushed
the
euclidean-differentiable-derived
branch
from
c541027 to
f4cf3d9
Compare
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
3 similar comments
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
…fferentiable-derived
…e.swift since the difference it has from derived_differentiable.swift is that it's a runtime test suite.
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
rxwei
added a commit
to rxwei/swift-apis
that referenced
this pull request
Aug 28, 2019
`EuclideanDifferentiable`, introduced in swiftlang/swift#26827 and swiftlang/swift#26867, provides a property, `differentiableVectorView`, to project the vector space component of a differentiable struct as a value of `TangentVector` type. This allows us to express optimization techniques that require the parameter space to be a vector space, e.g. weight decay. ```swift let 𝛁L: Model.TangentVector = ... model.move(along: -η * 𝛁L - η * λ * model.vectorView)) ``` Resolves tensorflow#456.
rxwei
added a commit
to tensorflow/swift-apis
that referenced
this pull request
Aug 28, 2019
`EuclideanDifferentiable`, introduced in swiftlang/swift#26827 and swiftlang/swift#26867, provides a property, `differentiableVectorView`, to project the vector space component of a differentiable struct as a value of `TangentVector` type. This allows us to express optimization techniques that require the parameter space to be a vector space, e.g. weight decay: ```swift let 𝛁L: Model.TangentVector = ... model.move(along: -η * 𝛁L - η * λ * model.differentiableVectorView)) ``` This patch makes `Module` refine `EuclideanDifferentiable` and makes all layer combinators (e.g. `Sequential`, `RNN`) be `EuclideanDifferentiable`. All `Module`s and `Layers`s will now have property `differentiableVectorView`. Resolves #456.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add derived conformances for the
EuclideanDifferentiableprotocol introduced in Disable property wrapper composition. #26287 when a conforming type satisfiesDifferentiableconformance synthesis requirements.Remove
vectorView's setter. This should not have been added to the protocol, for the same reason as TF-208. A projection (vectorView) of a subset of properties should reflect these properties joint mutability, which is impossible to express at the moment.Resolves TF-777.