[AutoDiff] AD associated function linker error fix. #26429
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt linker error fix regarding AD associated functions of `PublicNonABI` functions (default argument closures). Standalone test (not using SwiftPM) to be created. May resolve TF-690.
|
To be tested: revert @pschuh: would you like to continue looking into this? |
|
Any updates? |
dan-zheng
force-pushed
the
tensorflow
branch
from
6dcf239 to
04dca63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt linker error fix regarding AD associated functions of
PublicNonABIfunctions (default argument closures).Patch by @rxwei.
Standalone test (not using SwiftPM) to be created.
May resolve TF-690.