[AutoDiff] improve symbol linkage #28582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
approved these changes
Dec 5, 2019
|
@swift-ci please test tensorflow |
rxwei
reviewed
Dec 5, 2019
| @@ -823,7 +823,8 @@ void SILGenModule::emitDifferentiabilityWitness( | |||
| auto *diffWitness = SILDifferentiabilityWitness::createDefinition( | |||
| M, originalFunction->getLinkage(), originalFunction, loweredParamIndices, | |||
| config.resultIndices, config.derivativeGenericSignature, | |||
| /*jvp*/ nullptr, /*vjp*/ nullptr, originalFunction->isSerialized(), | |||
| /*jvp*/ nullptr, /*vjp*/ nullptr, | |||
| /*isSerialized*/ hasPublicVisibility(originalFunction->getLinkage()), | |||
There was a problem hiding this comment.
We probably shouldn't always serialize witnesses for any public declarations, because things we emit should be opaque by default. Maybe you should add logic to the cross module optimizer that was recently added (#28407) to make differentiability witnesses serialized.
There was a problem hiding this comment.
I'll do this later because this PR is now very tested and almost ready to go. https://bugs.swift.org/browse/TF-1035
rxwei
approved these changes
Dec 5, 2019
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow macos |
This was referenced Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements most of the symbol linkage design, enough to fix two linker issues: TF-690 & TF-1025. (There are a few other linker issues in JIRA. I'll check later if this fixes any of those).
Specific changes:
This PR does not include the following pieces of the design:
This seems "dangerous" so I'll run swift-apis and swift-models tests on it. (e.g. without tensorflow/swift-apis#573, swift-apis would fail to compile after this PR).