Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

remove default argument closures #573

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

marcrasi
Copy link
Contributor

@marcrasi marcrasi commented Dec 4, 2019

Differentiable closures as default arguments do not work (https://bugs.swift.org/browse/TF-690), so this PR removes them.

Soon, a diagnostic will forbid differentiable closures as default arguments, as decided in Swift AD Symbol Linkage.

Eventually, we implement a solution that allows differentiable closures as default arguments (https://bugs.swift.org/browse/TF-1030). When that happens, we can remove _sum and _mean.

@marcrasi marcrasi requested a review from dan-zheng December 4, 2019 22:09
@marcrasi marcrasi merged commit 8aed72e into master Dec 5, 2019
@marcrasi marcrasi deleted the marcrasi-remove-default-arg-closures branch December 5, 2019 00:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants