[SR-1639] Fix linker errors for sourcekitd when in-process #2769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several SourceKit symbols are declared in `sourcekitd/sourcekitd.h` and `sourcekitd/Internal.h`, but are only implemented for OS X, in `tools/SourceKit/tools/sourcekitd/lib/API/sourcekitdAPI-XPC.cpp`. These need implementations that are only included in builds of SourceKit that use an in-process communication model (in other words, not XPC). Add stub implementations of the undefined symbols for in-process builds. This reduces the number of linker errors, getting us closer to at least *compiling* SourceKit on Linux. Of course, these stub functions will not work at runtime, they'll just let us compile.
modocache
force-pushed
the
sr-1639-sourcekitd-in-process-definitions
branch
from
b5b844e to
35f2dee
Compare
modocache
changed the title
| set(LLVM_OPTIONAL_SOURCES ${sourcekitdAPI_Darwin_sources}) | ||
| if(APPLE) | ||
| list(APPEND sourcekitdAPI_sources ${sourcekitdAPI_Darwin_sources}) | ||
| set(sourcekitdAPI_InProc_sources sourcekitdAPI-InProc.cpp) |
There was a problem hiding this comment.
I think it is important that the concept of "Darwin sources" be preserved here. When building on Mac, both the standard and in-proc versions of sourcekitd use XPC services to implement these APIs. In the case of in-proc library, xpc_object_t is effectively used as a flexible DTO to implement the SourceKit request object.
An alternative implementation will indeed be required though for Linux, perhaps using some sort of C++ variant type. I've just begun poking looking into what this could look like but haven't gotten very far.
1 task
1 task
|
This is now obsoleted by #3000 Thanks for having helped get the ball rolling with this work @modocache! |
|
My pleasure, thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Several SourceKit symbols are declared in
sourcekitd/sourcekitd.handsourcekitd/Internal.h, but are only implemented for OS X, intools/SourceKit/tools/sourcekitd/lib/API/sourcekitdAPI-XPC.cpp. These need implementations that are only included in builds of SourceKit that use an in-process communication model (in other words, not XPC).Add stub implementations of the undefined symbols for in-process builds. This reduces the number of linker errors, getting us closer to at least compiling SourceKit on Linux. Of course, these stub functions will not work at runtime, they'll just let us compile.
Resolved bug number: (SR-1639)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.