[SE-0025][SR-1275] fileprivate [1/2] #3000
Conversation
|
I apologize for the enormous batch of changes here. But most of it is plumbing through the new shiny. |
|
@swift-ci Please test |
|
Not sure what to do about the tests here. This is going to require submissions to SwiftPM and Foundation to migrate them to fileprivate and fix the build. |
|
Would it make sense to add |
|
@ddunbar How would we disambiguate between |
|
The migration path here is all existing uses of |
|
@modocache If I understood correctly, the suggestion is that we introduce just the syntax in the first patch, thus avoiding the need for lockstep changes. |
CodaFi
force-pushed
the
my-fileprivate-eyes
branch
from
9b04220 to
053c2ad
Compare
|
OK, the two keywords now temporarily point to the same accessibility constraint. |
CodaFi
changed the title
|
@swift-ci please test |
CodaFi
force-pushed
the
my-fileprivate-eyes
branch
from
053c2ad to
afbc99f
Compare
|
Once more with feeling. |
|
@swift-ci please test |
The majority of changes here are just plumbing needed to get the compiler to look at the (new!) FilePrivate as the (old!) Private and the (new!) Private as an even more closed-off form the of (old!) Private. The interesting changes are in `lib/AST/NameLookup.cpp` where (new!) private is defined as a declaration where our declcontext and their declcontext have to match or nest. (new!) Private predictably causes quite a lot more dead code elimination to fire in places which has lead to some interesting bugs that I will see about patches for (or at least SRs).
CodaFi
force-pushed
the
my-fileprivate-eyes
branch
from
afbc99f to
fb9f953
Compare
|
@swift-ci please test |
|
OK, we've finished staging the corelibs changes for this patch (thanks @modocache for doing corelibs-XCTest). Should be smooth sailing. |
|
Looks like this branch could use a rebase. Just curious: what's the plan for merging this? Are we waiting on something, or is this good to go? |
|
@CodaFi found a problem in the proposal and we need to discuss it first. |
|
This is now subsumed by #3391 |
Make versions of Yams and SAP match upstream Versions that we currently use are old and don't support ARM64 builds on Apple Silicon.
What's in this pull request?
Implements the
fileprivateaccess level described in SE-0025.Resolved bug number: (SR-1275)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.