[build-script] use explicit build/test list between build-script and build-script-impl #2780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(and appropriate test flags) with an explicit build and test list.
|
Thank you! I don't like the current system of "skip" flags. It makes it hard to understand what a set of flags will do. This arrangement is a historical curiosity, from the time when we only started to port Swift to iOS, and we added a |
|
Half of the code for this is in another commit. I'll fix it up when my current build finishes and reopen. |
|
Sure, when you're ready! |
| build_script_impl_args += ["--skip-test-watchos-simulator"] | ||
| skip_test_tgts += StdlibDeploymentTarget.AppleWatchSimulator.allArchs | ||
|
|
||
| # FIXME: Do the tests work for Android? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Instead of having lots of different
skip-[platform]andskip-test-[platform]flags for every stdlib SDK, use an explicit list of targets to build and test.There are no outward-facing changes. The build and test list are calculated from the same
- - ios, etc flags as they are today. This only affects howbuild-scripttellsbuild-script-implwhich targets to build/test. It simplifies stdlib target calculation, and gives us the opportunity to override it with more granular options (e.g. just building one stdlib deployment target, not a whole SDK, or just building tests for one target).Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
(and appropriate test flags) with an explicit build and test list.