[build-script] use explicit build/test list between build-script and build-script-impl #2804
Conversation
karwa
force-pushed
the
swift-build-test-list
branch
2 times, most recently
from
f99dd53 to
7b8d70b
Compare
(and appropriate test flags) with an explicit build and test list. Made configuration message more visible and obvious
karwa
force-pushed
the
swift-build-test-list
branch
from
7b8d70b to
0a0fe14
Compare
only supports android-armv7.
|
@swift-ci Please test |
|
@swift-ci Please smoke test |
|
Not a review, just triggering the CI. |
| if not args.ios or args.skip_build_ios: | ||
| # --long-test implies --test. | ||
| if args.long_test: | ||
| args.test = True |
There was a problem hiding this comment.
This is not true.
See 457f2b9 for intent of --long-test
If so, you shouldn't have to modify |
|
@rintaro You're right that I don't have to, but lots of the calculations there were redundant from a perspective of an explicit build list derived from a restricted list of configured targets, and then a test list derived from a restricted list of build targets. Not only that, but it hid away some vital details, like the fact that iOS targets are sort configured backwards - rather than being configured and built by default, they are configured by default and skipped from building unless you add the it may be possible to put some of the other argument-shuffling back, but actually breaking build/test list generation out is probably a better idea. I'm going to change this to create some sort of |
|
This and #2880 are going to conflict heavily, so we should probably figure out which makes sense to land first if we are going to go both directions. |
|
I would suggest that we go with #2880. It is more aggressive, but it should allow us to get rid of the shell script quicker. Any concerns? |
|
Shelved until build-script-impl is removed |
What's in this pull request?
Instead of having lots of different skip-[platform] and skip-test-[platform] flags for every stdlib SDK, use an explicit list of targets to build and test.
There are no outward-facing changes (besides a more verbose and obvious configuration message). The build and test list are calculated from the same
--ios, etc flags as they are today. This only affects howbuild-scripttellsbuild-script-implwhich targets to build/test. It simplifies stdlib target calculation, and gives us the opportunity to override it with more granular options (e.g. just building one stdlib deployment target, not a whole SDK, or just building tests for one target).Reopened from #2780
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
(and appropriate test flags) with an explicit build and test list.
Made configuration message more visible and obvious