-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[requires-evolution] Conditionally compiled catch clauses #27905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
46559c2
to
d99a249
Compare
This is passing the regular test suite locally now. If anyone sees this I'd be interested in seeing how it fares on the source compatibility suite |
Can you fix the merge conflict? We can run a source compat test after that |
d99a249
to
617336a
Compare
@swift-ci please test source compatibility |
1 similar comment
@swift-ci please test source compatibility |
Hmm, looks like a couple of failures but nothing too bad. Thanks @theblixguy! |
617336a
to
0187b8b
Compare
Let's see if this works @swift-ci please test |
a5efcc6
to
bfe13f7
Compare
5311cdb
to
75f1bfe
Compare
… sure libSyntax works this time
…e round trip test to include a multi-pattern catch
…d unwanted optionality
af6e6bb
to
889d8cd
Compare
For my own future reference: swiftlang/swift-syntax#190 and swiftlang/llvm-project#538 contain the LLDB and swift-syntax changes needed to build a working toolchain. |
889d8cd
to
fe64516
Compare
@DougGregor do you mind kicking off a toolchain build with the two PRs I linked in the comment above? I've tested this locally and was able to build a working macOS toolchain. |
@swift-ci please build toolchain |
swiftlang/swift-syntax#190 @swift-ci please build toolchain |
Ugh, thanks @theblixguy! I totally missed previous comment... |
macOS Toolchain Install command |
Closing because conditional compilation was dropped from the final proposal |
This is based on #27776, so only the last 2 commits are relevant. It's a WIP for now because I broke code completion (again), but everything else is working so I plan on pitching this on the forums shortly.
This change makes the following legal: