Skip to content

Update gyb generated files for multi-pattern catch clauses (SE-0276) #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

owenv
Copy link
Contributor

@owenv owenv commented Jan 8, 2020

This is the swift-syntax counterpart to swiftlang/swift#27776 and swiftlang/swift#27905 , updating the gyb-generated files to reflect the compiler changes. Catch clauses may now have a comma-separated list of patterns

@owenv owenv force-pushed the catch_proposal_updates branch from eaf66a5 to 6864d63 Compare January 10, 2020 05:09
@owenv owenv force-pushed the catch_proposal_updates branch from 6864d63 to af828c2 Compare January 29, 2020 21:08
@owenv owenv changed the title [Do Not Merge]Update gyb generated files for catch clause proposal Update gyb generated files for multi-pattern catch clauses (SE-0276) Jan 29, 2020
@owenv owenv requested a review from akyrtzi February 3, 2020 21:28
@akyrtzi akyrtzi requested a review from rintaro February 3, 2020 21:48
Copy link
Member

@rintaro rintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just to make sure. These changes are auto generated, right?

@owenv
Copy link
Contributor Author

owenv commented Feb 6, 2020

@rintaro Thanks! Yeah, this is entirely auto generated, I probably should have mentioned that somewhere

@akyrtzi
Copy link
Contributor

akyrtzi commented Feb 6, 2020

Let us know when ready to merge.

@rintaro
Copy link
Member

rintaro commented Apr 6, 2020

swiftlang/swift#30811
@swift-ci test

@DougGregor DougGregor merged commit 2722ad0 into swiftlang:master Apr 7, 2020
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
…enting

Use real line number when moving block indentation for close breaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants