[SE-0276] Syntax and Parse updates #30811
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th the old AST This will be reverted once full support lands
owenv
added
the
swift evolution approved
|
@swift-ci please test |
owenv
changed the title
|
@swift-ci please test source compatibility |
|
@rintaro thank you! I also forgot to mention, I'm not sure if the rest of the SE-276 changes will be reviewed and merged before the 5.3 branch cut in a couple weeks. In that case, should we wait to merge this to avoid changing the swift-syntax API? If you think this is ok to merge now, do you mind helping merge this alongside swiftlang/swift-syntax#190? I don't have commit access to swift-syntax. |
|
@DougGregor @CodaFi Do you think you can review and merge the rest of #27776 by the branch cut? Discussion: https://forums.swift.org/t/landing-se-0276-implementation/35093 |
|
#27776 has landed |
|
The main PR has been merged, so do we close this one? |
|
yeah, this is no longer needed, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is a cherry-pick of the Parse and Syntax changes from #27776 and reviewed by @rintaro, the second is the minimal set of changes needed to make them work with the old AST, plus a diagnostic saying the new syntax isn't yet supported.
The goal is to land the corresponding swift-syntax PR alongside this so the rest of #27776 becomes more manageable and easier to review.