[NFC] Squash Out Some More TypeChecker Dependencies #27964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
hamishknight
approved these changes
Oct 30, 2019
Make it less tempting to ask for the type checker embedded into ConstraintSystem by using the accessor to the ASTContext.
CodaFi
force-pushed
the
is-this-a-dynamic-language
branch
from
e4cf7a5 to
abc6db1
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downgrade a bunch of parts of the Sema that thought they needed a TypeChecker, but really just needed an ASTContext. The great success here is
DerivedConformance, which now only requires the type checker in one place, and that place is conformance checking. The end goal is to completely decouple conformance checking from a type checker instance anyways, so there should be a follow-up here that squashes out even more fromTypeCheckProtocol[Inference].