Don't unnecessarily force InterfaceTypeRequest #28040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
CodaFi
approved these changes
Nov 3, 2019
theblixguy
reviewed
Nov 3, 2019
slavapestov
force-pushed
the
dont-force-the-issue
branch
from
080be50 to
b1c34d0
Compare
slavapestov
force-pushed
the
dont-force-the-issue
branch
from
b1c34d0 to
77e4948
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In various places, we were still calling
(void) foo->getInterfaceType()to force the interface type to be computed. This was a transitional step to migrate code offvalidateDecl(). We've now refactored enough code that this should no longer be necessary.