[AutoDiff] Emit SIL diff witnesses into original function's IRGenModule. #28237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test tensorflow |
marcrasi
approved these changes
Nov 13, 2019
The differentiation transform does not yet canonicalize differentiability witnesses so that they always have JVP/VJP functions. TF-894 tracks this. Until then, emit SIL differentiability witness into the IRGenModule for the original function. This significance of this is unclear; `IRGenerator::getGenModule` seems relevant only for multi-threaded compilation. Resolves TF-960: crash when `SILDifferentiabilityWitness::getVJP` is null.
dan-zheng
changed the title
|
@swift-ci Please test tensorflow |
|
@swift-ci Please test tensorflow macOS |
dan-zheng
added a commit
that referenced
this pull request
Nov 14, 2019
…le. (#28237) The differentiation transform does not yet canonicalize differentiability witnesses so that they always have JVP/VJP functions. TF-894 tracks this. Until then, emit SIL differentiability witness into the IRGenModule for the original function. The significance of this is unclear; `IRGenerator::getGenModule` seems relevant only for multi-threaded compilation. Resolves TF-960: crash when `SILDifferentiabilityWitness::getVJP` is null.
bgogul
pushed a commit
that referenced
this pull request
Nov 19, 2019
…le. (#28237) The differentiation transform does not yet canonicalize differentiability witnesses so that they always have JVP/VJP functions. TF-894 tracks this. Until then, emit SIL differentiability witness into the IRGenModule for the original function. The significance of this is unclear; `IRGenerator::getGenModule` seems relevant only for multi-threaded compilation. Resolves TF-960: crash when `SILDifferentiabilityWitness::getVJP` is null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The differentiation transform does not yet canonicalize differentiability
witnesses so that they always have JVP/VJP functions. TF-894 tracks this.
Until then, emit SIL differentiability witness into the IRGenModule for
the original function. This significance of this is unclear;
IRGenerator::getGenModuleseems relevant only for multi-threadedcompilation.
Resolves TF-960: crash when
SILDifferentiabilityWitness::getVJPis null.