Skip to content
This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Test swift build -c release for auxiliary repositories. #553

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

dan-zheng
Copy link
Member

Test swift build -c release (compilation with -O) for
tensorflow/swift-models and fastai/fastai_dev.

Motivated by recently discovered -O-specific issues (TF-960).

Test `swift build -c release` (compilation with `-O`) for
tensorflow/swift-models and fastai/fastai_dev.

Motivated by recently discovered `-O`-specific issues (TF-960).
@dan-zheng
Copy link
Member Author

Note that swift build -c release is expected to fail for tensorflow/swift-models until TF-960 is resolved.

@marcrasi
Copy link
Contributor

LGTM, but let's wait until TF-960 is fixed and then rerun kokoro to confirm it passes, and then merge this. So that we don't block the rapid build in the meantime.

@dan-zheng
Copy link
Member Author

CI passes now that swiftlang/swift#28237 has landed.
Merging.

@dan-zheng dan-zheng merged commit c47db87 into tensorflow:master Nov 14, 2019
@dan-zheng dan-zheng deleted the test-optzns branch November 14, 2019 10:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants