Handle Boolean literals as enum raw values. #28274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Is the depth map stuff supposed to be attached? |
I got lazy, sorry; it's also in the more purposeful #28276 |
CodaFi
reviewed
Nov 15, 2019
| } | ||
|
|
||
| // expected-error@+1{{'IsRecursive' declares raw type 'Bool', but does not conform to RawRepresentable and conformance could not be synthesized}} | ||
| enum IsRecursive : Bool, Equatable, Hashable { |
There was a problem hiding this comment.
Some more tests: an @objc enum (and if we allow this, an IRGen test), an enum with an invalid raw value expression.
There was a problem hiding this comment.
@objc enums are banned; I've added more tests
Fixes rdar://problem/55384273.
DougGregor
force-pushed
the
bool-raw-value
branch
from
3821c86 to
21a7fba
Compare
|
@swift-ci please smoke test and merge |
3 similar comments
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/55384273.