Skip to content

[Constraint solver] Remove expression from the constructor. #28276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 15, 2019
Merged

[Constraint solver] Remove expression from the constructor. #28276

merged 5 commits into from
Nov 15, 2019

Conversation

DougGregor
Copy link
Member

Rather than setting up the constraint solver with a single expression
(that gets recorded for parents/depths), record each expression that
goes through constraint generation.

@DougGregor
[Constraint system] Sink Expr::getDepthMap() into its one client.
01f203a 
NFC. It'll be easier to refactor this when it's not an API on Expr.
@DougGregor
[Constraint solver] Lazily populate the expression depth/index map.
9b9aa23
@DougGregor
[Constraint solver] Remove expression from the constructor.
2d915f6 
Rather than setting up the constraint solver with a single expression
(that gets recorded for parents/depths), record each expression that
goes through constraint generation.
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor DougGregor requested a review from hborla November 14, 2019 23:58
@DougGregor DougGregor mentioned this pull request Nov 15, 2019
Merged
xedin
xedin reviewed Nov 15, 2019
View reviewed changes
Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My two cents are related to the fact that we don't really need to recompute the weights for the individually type-checked sub-expressions in CSDiag all of the sub-CSs could refer to the original one for this.

@DougGregor
Copy link
Member Author

My two cents are related to the fact that we don't really need to recompute the weights for the individually type-checked sub-expressions in CSDiag all of the sub-CSs could refer to the original one for this.

Ah, sure. At the very least, we can look up the chain first.

@DougGregor
[Constraint system] Look for parent/depth info in base constraint sys…
abf41e7 
…tem.

Look first in the base constraint system for this information, so it
only gets built once in the normal case.
@DougGregor
Copy link
Member Author

@swift-ci please smoke test

@DougGregor DougGregor merged commit 0b6ef0d into swiftlang:master Nov 15, 2019
@DougGregor DougGregor deleted the constraint-solver-expr-ctor branch November 15, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin left review comments

@hborla hborla Awaiting requested review from hborla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DougGregor @xedin