[IDE] Enable 'IgnoreSwiftSourceInfo' in code completion #28282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get source locations from '.swiftsourceinfo' is currently expensive. Since they are not necessary for code completion, set 'IgnoreSwiftSourceInfo' to 'true'. rdar://problem/57194358 https://bugs.swift.org/browse/SR-11767
|
@swift-ci Please smoke test |
|
There seems to be a lot of places that needed update, how about adding some |
|
I agree we should have some unified place for adjusting invocation/instance for completion operations. We already have some duplicated code between completion/typecontextinfo/conformingmethodlist. I will see how we could consolidate them. |
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting source locations from
.swiftsourceinfois currently expensive. Since they are not necessary for code completion, setIgnoreSwiftSourceInfototrue.rdar://problem/57194358
https://bugs.swift.org/browse/SR-11767
(This reduces the testing time for
IDE/complete_value_expr.swiftfrom 29sec to 22sec).