[SourceKit/swift-ide-test] Consolidate duplicated logics between completion like requests #28322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get source locations from '.swiftsourceinfo' is currently expensive. Since they are not necessary for code completion, set 'IgnoreSwiftSourceInfo' to 'true'. rdar://problem/57194358 https://bugs.swift.org/browse/SR-11767
Align with code completion.
Specifically, align with swiftTypeContextInfoImpl() and swiftConformingMethodListImpl()
Consolidate duplicated logics between completion/typecontextinfo/conformingmethodlist requests. SourceKit: SwiftLangSupport::setupCompilerInstanceForCodeCompletion() swift-ide-test: doCodeCompletionImpl()
|
@swift-ci Please test |
akyrtzi
reviewed
Nov 18, 2019
| @@ -295,6 +296,45 @@ SwiftLangSupport::makeCodeCompletionMemoryBuffer( | |||
| return std::unique_ptr<llvm::MemoryBuffer>(newBuffer.release()); | |||
| } | |||
|
|
|||
| bool SwiftLangSupport::setupCompilerInstanceForCodeCompletion( | |||
There was a problem hiding this comment.
Should this move to lib/IDE so swift-ide-test can also use it and ensure that swift-ide-test performs code-completion the same way as sourcekitd?
|
Superseded by #28727 . Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(based on #28282 I'll rebase this after that PR is merged)
Consolidate duplicated logics between completion like requests: code completion, type context info, and conforming method list.
typecontextinfoandconformingmethodsrequests too.SwiftLangSupport::setupCompilerInstanceForCodeCompletion()doCodeCompletionImpl()