[build] Refer to projects through the monorepo directly #28296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why am I doing this? Because we have now switched to the monorepo, we no longer need to have logic to detect whether or not a project is present. Any project under the llvm project is guaranteed to be available if you're building llvm. I hope this is the first change of many that can clean up some of the logic in build-script-impl. Some simplifications and cleanups that I think can be made include: - Adding the option to build swift as a part of the llvm build. (Or even making this the default behavior) - Taking advantage of `LLVM_ENABLE_PROJECTS` to simplify some of the logic to set up clang, clang-tools-extra, and other projects.
|
@swift-ci please test |
|
@swift-ci build toolchain |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
macOS Toolchain Install command |
|
Thanks @xiaobai! |
|
We should also cherry-pick this to swift-5.1-branch. |
|
We are seeing build failure if we remove the symlink |
|
@shahmishal I can cherry-pick it to the swift-5.1-branch sure. I also can take a look at why removing the symlinks fails. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why am I doing this?
Because we have now switched to the monorepo, we no longer need to have logic to
detect whether or not a project is present. Any project under the llvm project
is guaranteed to be available if you're building llvm.
I hope this is the first change of many that can clean up some of the logic in
build-script-impl. Some simplifications and cleanups that I think can be made
include:
this the default behavior)
LLVM_ENABLE_PROJECTSto simplify some of the logic toset up clang, clang-tools-extra, and other projects.
cc @compnerd @Rostepher @gottesmm @shahmishal @brentdax