Skip to content

[build] amend search path for Cmake modules #28334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Nov 18, 2019

Since we are not using symlinks anymore, we need to point to the correct
directory with LLVM cmake modules.

Fixes rdar://problem/57294763

Since we are not using symlinks anymore, we need to point to the correct
directory with LLVM cmake modules.

Fixes rdar://problem/57294763
@edymtt edymtt requested a review from shahmishal November 18, 2019 21:37
@edymtt
Copy link
Contributor Author

edymtt commented Nov 18, 2019

@swift-ci please test Windows

@edymtt
Copy link
Contributor Author

edymtt commented Nov 18, 2019

This is related to #28296

@edymtt edymtt requested review from clackary and Rostepher November 18, 2019 21:39
@edymtt
Copy link
Contributor Author

edymtt commented Nov 18, 2019

@swift-ci please test Windows

@edymtt
Copy link
Contributor Author

edymtt commented Nov 18, 2019

@swift-ci please test Windows

3 similar comments
@edymtt
Copy link
Contributor Author

edymtt commented Nov 18, 2019

@swift-ci please test Windows

@edymtt
Copy link
Contributor Author

edymtt commented Nov 18, 2019

@swift-ci please test Windows

@edymtt
Copy link
Contributor Author

edymtt commented Nov 18, 2019

@swift-ci please test Windows

@drodriguez
Copy link
Contributor

Can you please try with "please clean test Windows platform" if the last one fails? Thanks!

@edymtt
Copy link
Contributor Author

edymtt commented Nov 18, 2019

Thanks for the tip!
This time the build started fine, but I will remember this for the future.

@edymtt
Copy link
Contributor Author

edymtt commented Nov 18, 2019

@swift-ci please smoke test

@edymtt edymtt merged commit c0c247e into swiftlang:master Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants