[AutoDiff] Update API/ABI status for attributes. #28302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
commented
Nov 16, 2019
| NotSerialized, 91) | ||
| SIMPLE_DECL_ATTR(compilerEvaluable, CompilerEvaluable, | ||
| OnAccessor | OnFunc | OnConstructor | OnSubscript | | ||
| ABIStableToAdd | ABIStableToRemove | APIStableToAdd | APIStableToRemove | | ||
| NotSerialized, 92) | ||
| SIMPLE_DECL_ATTR(noDerivative, NoDerivative, | ||
| OnVar | | ||
| ABIStableToAdd | ABIStableToRemove | APIStableToAdd | APIStableToRemove, | ||
| ABIBreakingToAdd | ABIBreakingToRemove | APIBreakingToAdd | APIBreakingToRemove, |
There was a problem hiding this comment.
Note: I made the stylistic choice to intentionally leave this line >80 columns so all the API/ABI statuses can be on one line.
|
@swift-ci Please test tensorflow |
rxwei
approved these changes
Nov 16, 2019
`@differentiating` and `@transposing` are: - API/ABI stable to add. (The declaration is unaffected.) - API/ABI breaking to remove. `@noDerivative` is API/ABI breaking to add/remove. Adding/removing the attribute changes derivative code behavior.
dan-zheng
force-pushed
the
∂p-attributes
branch
from
6fba0a2 to
a5ff0ee
Compare
|
@swift-ci Please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@differentiatingand@transposingare:@noDerivativeis API/ABI breaking to add/remove.Adding/removing the attribute changes derivative code behavior.