Skip to content

[AutoDiff] Update API/ABI status for attributes. #28410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2019

Conversation

dan-zheng
Copy link
Contributor

@differentiating and @transposing are:

  • API/ABI stable to add. (The declaration is unaffected.)
  • API/ABI breaking to remove.

@noDerivative is API/ABI breaking to add/remove.
Adding/removing the attribute changes derivative code behavior.


Mirror of #28302, which was merged but became lost in the tensorflow
branch commit history for some reason.

`@differentiating` and `@transposing` are:
- API/ABI stable to add. (The declaration is unaffected.)
- API/ABI breaking to remove.

`@noDerivative` is API/ABI breaking to add/remove.
Adding/removing the attribute changes derivative code behavior.
@dan-zheng dan-zheng requested review from rxwei and marcrasi November 21, 2019 17:57
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test tensorflow

@dan-zheng dan-zheng merged commit 6104e74 into swiftlang:tensorflow Nov 21, 2019
@dan-zheng dan-zheng deleted the ∂p-attributes branch November 21, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants