SE-0036 (1/3): Update existing tests for the upcoming implementation #2841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if A == B { } | ||
| return A.hashValue | ||
| return Generic.A.hashValue |
There was a problem hiding this comment.
Do we really need static? I'd prefer to stick to the original code as close as possible.
There was a problem hiding this comment.
This change was based on the comment by @jrose-apple on a previous PR: #2224 (comment)
But I can change it to be non-static if you think that’s better
There was a problem hiding this comment.
Yep. This test is supposed to be testing synthesis of == without any member lookup being done, because that goes through a different path in the compiler. (Feel free to add that as a comment!)
|
@swift-ci Please test |
This was referenced Jun 2, 2016
ahoppen
changed the title
ahoppen
force-pushed
the
SR-1236-tests-update
branch
from
0a8ff0d to
2108a23
Compare
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This is Part 1/3 implementing SE-0036:
This updates the existing tests to comply with SE-0036 and is fully backwards compatible
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.