SE-0036 (3/3): Provide errors when referencing enum elements on instances #2843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
| @@ -139,6 +139,8 @@ Swift 3.0 | |||
| `NS[Mutable]Dictionary` are still imported as nongeneric classes for | |||
| the time being. | |||
|
|
|||
| * [SE-0036](https://github.com/apple/swift-evolution/blob/master/proposals/0036-enum-dot.md): | |||
| Enum elements can no longer be accessed like instance members in instance methods. | |||
There was a problem hiding this comment.
Please add a newline after for consistency
|
@DougGregor or @lattner can you take a look at this patch? |
|
I guess this will still need to be merged for Swift 3 |
|
@swift-ci please smoke test and merge |
…members This removes the logic which issued warnings when accessing enum elements as instance members (SE-0036), making room for a new implementation that will issue errors instead. This reverts commit ae1058a.
This implements SE-0036.
|
The LLDB failures are real... it looks like there are a few test cases that need to be updated there. @ahoppen, can you create a PR against LLDB to fix up those errors? We'll merge that one first. |
|
LLDB pull request is created apple/swift-lldb#35 |
|
@swift-ci please smoke test and merge |
|
LLDB PR merged, so I kicked off another round of smoke-test-and-merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This is part 3/3 implementing SE-0036.
It undos the changes done in #2842 that provided warnings when an enum element was referenced on an enum and implements a different logic that throws errors instead.
It has slightly better fix-its than the warning-based approach because it can also detect if a single dot suffices as a fix-it in expressions where the type can be inferred on the context, e.g. in
self = .A. However, it looses the ability to infer a single-dot fix-it incasestatements for generic enums.The resulting code is basically the same as in #2634.
Dependencies
Same text as in #2842:
I wasn’t sure how I should handle the multi-staged rollout of SE-0036 as described here. So this PR includes the changes to the test cases that shall be merged in #2841 and #2842 and builds on top of them, i.e. the branch for this PR is two commits ahead of the one for #2842. I hope that’s the right way to go, otherwise let me know.
Resolved bug number: (SR-1236)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.