[CodeCompletion] Use getBodySourceRange() instead of getSourceRange() #28944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
To check if the completion is happening in the AFD body. Otherwise, local variables are sometimes not suggested because the body and its range is from another file. rdar://problem/58175106
rintaro
force-pushed
the
ide-completion-rdar58175106
branch
from
e237fa3 to
046c914
Compare
|
@swift-ci Please smoke test |
nathawes
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To check if the completion is happening in the AFD body.
Otherwise, local variables are sometimes not suggested because the range checking is confused by the fast completion (i.e. the body and its range may be from another file).
rdar://problem/58175106