Skip to content

[Diagnostics] Removing FailureDiagnosis::visitCoerceExpr from CSDiag #29064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 8, 2020
Merged

[Diagnostics] Removing FailureDiagnosis::visitCoerceExpr from CSDiag #29064

merged 7 commits into from
Jan 8, 2020

Conversation

LucianoPAlmeida
Copy link
Contributor

Follow up #29011, fixing the remaining failures diagnostics and removing FailureDiagnosis::visitCoerceExpr from CSDiag.

cc @xedin @hborla

@xedin xedin self-requested a review January 8, 2020 04:01
@xedin
Copy link
Contributor

xedin commented Jan 8, 2020

@swift-ci please smoke test

@LucianoPAlmeida LucianoPAlmeida force-pushed the handle-csdiag-coerce-diagnostics branch 2 times, most recently from 38f2f2e to a88f3fb Compare January 8, 2020 10:10
@LucianoPAlmeida LucianoPAlmeida force-pushed the handle-csdiag-coerce-diagnostics branch from a88f3fb to 4443966 Compare January 8, 2020 10:11
@xedin
Copy link
Contributor

xedin commented Jan 8, 2020

@swift-ci please smoke test

@xedin xedin merged commit 7cfd3cb into swiftlang:master Jan 8, 2020
@LucianoPAlmeida
Copy link
Contributor Author

Thank you @xedin :))

@xedin
Copy link
Contributor

xedin commented Jan 8, 2020

@LucianoPAlmeida Thank you for taking care of it!

@hamishknight
Copy link
Contributor

hamishknight commented Jan 9, 2020 •
edited
Loading

I think this may be causing the source compat suite to fail for a few projects (https://ci.swift.org/job/swift-PR-source-compat-suite-debug/2157), looks like anchor is nullptr in the check isa<CoerceExpr>(anchor) in repairFailures when we do witness matching (see for example this crash log).

@xedin xedin mentioned this pull request Jan 9, 2020
Closed
@xedin
Copy link
Contributor

xedin commented Jan 9, 2020

@hamishknight I'm going to revert (#29084) but I'll also open a PR to address that. We definitely can get locators without an anchor but a valid path while comparing generics...

@xedin xedin mentioned this pull request Jan 9, 2020
Merged
@LucianoPAlmeida
Copy link
Contributor Author

@xedin Sorry for the issue, let me know if I can help with that? :)

@xedin
Copy link
Contributor

xedin commented Jan 9, 2020

No problem, I got it covered!

@LucianoPAlmeida
Copy link
Contributor Author

No problem, I got it covered!

Thank you so much 💯

@xedin
Copy link
Contributor

xedin commented Jan 9, 2020

@LucianoPAlmeida Could you please try to reduce a simple test-case from project crashes so we could include it into validation test?

@LucianoPAlmeida
Copy link
Contributor Author

@xedin Sure 👍

@LucianoPAlmeida LucianoPAlmeida mentioned this pull request Jan 9, 2020
Merged
@LucianoPAlmeida
Copy link
Contributor Author

@xedin Just added the test case #29095 :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xedin xedin xedin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LucianoPAlmeida @xedin @hamishknight