Skip to content

[validation-test] Adding validation test for generic function match #29095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LucianoPAlmeida
Copy link
Contributor

Follow up to #29064
Adding a validation test from a source compatibility test that crashed.

cc @xedin

@theblixguy
Copy link
Collaborator

theblixguy commented Jan 9, 2020

Here's a more minimised example which produces the same crash:

enum SomeEnum<T> {}

protocol FooProtocol {
  var closure: (String) -> SomeEnum<Int> { get }
}

struct ConcreteFoo<Value>: FooProtocol {
  let closure: (String) -> SomeEnum<Value>
}

@xedin
Copy link
Contributor

xedin commented Jan 9, 2020

Thank you @LucianoPAlmeida and @theblixguy! I case of validation tests - the smaller, the better and preferably without imports if possible, so if the example that @theblixguy mentioned produces the same result - let's take it.

@LucianoPAlmeida
Copy link
Contributor Author

Humm... sure, thank you @theblixguy, @xedin :)

@xedin
Copy link
Contributor

xedin commented Jan 9, 2020

Let's update this PR and get it merged :)

@LucianoPAlmeida LucianoPAlmeida force-pushed the validation-test-match-generic-signature branch from d1a28c8 to 27b01e3 Compare January 9, 2020 17:23
@xedin
Copy link
Contributor

xedin commented Jan 9, 2020

@swift-ci please smoke test

@LucianoPAlmeida
Copy link
Contributor Author

Tests are ok, should be good to go? :)

@slavapestov slavapestov merged commit c584ebd into swiftlang:master Jan 10, 2020
@LucianoPAlmeida LucianoPAlmeida deleted the validation-test-match-generic-signature branch January 21, 2020 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants