[AutoDiff upstream] Store @differentiable original declaration.
#29082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxwei
approved these changes
Jan 9, 2020
dan-zheng
commented
Jan 9, 2020
Store in `DifferentiableAttr` the original declaration on which the attribute is declared. The original declaration is resolved during parsing and deserialization (not yet upstreamed). Progress towards TF-828: upstream `@differentiable` attribute type-checking.
dan-zheng
force-pushed
the
autodiff-upstream
branch
from
efac8a0 to
4f7349b
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
Linux CI fails due to an unrelated error: CI for other PRs seem to fail with the same error, so I imagine it's a recent breakage that should be fixed soon. |
|
@swift-ci Please smoke test Linux platform |
|
@swift-ci Please smoke test |
|
Merging to unblock progress, happy to review additional feedback later! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store in
DifferentiableAttrthe original declaration on which the attributeis declared.
The original declaration is resolved during parsing and deserialization
(not yet upstreamed).
Progress towards TF-828: upstream
@differentiableattribute type-checking.@differentiableattribute type-checking mega-patch: #29091Tests exist on
tensorflowbranch and will be upstreamed later.Currently, not enough code has been upstreamed for meaningful testing.