[DNM] [AutoDiff upstream] @differentiable attribute type-checking.
#29091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store in `DifferentiableAttr` the original declaration on which the attribute is declared. The original declaration is resolved during parsing and deserialization (not yet upstreamed). Progress towards TF-828: upstream `@differentiable` attribute type-checking.
dan-zheng
force-pushed
the
autodiff-upstream-diff-attr
branch
from
cb5242d to
3337516
Compare
`@differentiable` attribute type-checking mega-patch. Upstreams all necessary code from `tensorflow` branch. This mega-patch is just for end-to-end testing. Code will be upstreamed incrementally.
dan-zheng
force-pushed
the
autodiff-upstream-diff-attr
branch
from
3337516 to
dfa65b8
Compare
This was referenced Jan 9, 2020
dan-zheng
force-pushed
the
autodiff-upstream-diff-attr
branch
2 times, most recently
from
b188b90 to
dfa65b8
Compare
|
Closing now, as all changes have been split up and upstreamed separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@differentiableattribute type-checking mega-patch.Upstreams all necessary code from
tensorflowbranch.This mega-patch is just for end-to-end testing.
Code will be upstreamed incrementally.
Current status:
AutoDiff/Sema/differentiable_attr_type_checking.swiftpasses.Mega-patch success.
Todos:
DifferentiableAttributeTypeCheckRequest::evaluateAnyFunctionType::getAutoDiffDerivativeFunctionTypeAutoDiff/Sema/differentiable_attr_type_checking.swift. Maybe not initially.tensorflowbranch.