[AutoDiff upstream] Add @differentiable ASTScope support.
#29171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@differentiable` attributes may contain `where` clauses referencing generic parameters from some generic context, just like `@_specialize` attributes. Without special ASTScope support for `@differentiable` attributes, ASTScopeLookup.cpp logic tries to resolve the generic parameter `DeclName`s in `where` clauses based on source location alone (`ASTScopeImpl::findChildContaining`) and fails. The fix is to add a special `DifferentiableAttributeScope`, mimicking `SpecializeAttributeScope`. Every `@differentiable` attribute has its own scope, derived from the declaration on which it is declared. Unlike `@_specialize`, `@differentiable` may also be declared on `AbstractStorageDecl` declarations (subscripts and variables). Upstreams swiftlang#27451. Progress towards TF-828: upstream `@differentiable` attribute type-checking.
rxwei
approved these changes
Jan 13, 2020
|
Let's see if tests pass. They should! |
|
Build failed |
|
@swift-ci Please smoke test macOS platform |
|
Merging now to unblock progress, happy to address feedback later! @davidungar previously reviewed #29171 (this patch) in an email discussion on #25263 and said it looked fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@differentiableattributes may containwhereclauses referencinggeneric parameters from an outer scope, just like
@_specializeattributes.@differentiableattribute where clauses may refer to generic parameters fromsome generic context, just like
@_specializeattribute.Without special ASTScope support for
@differentiableattributes,ASTScopeLookup.cpp logic tries to resolve the generic parameter
DeclNames inwhereclauses based on source location alone(
ASTScopeImpl::findChildContaining) and fails.The fix is to add a special
DifferentiableAttributeScope, mimickingSpecializeAttributeScope. Every@differentiableattribute has its own scope,derived from the declaration on which it is declared. Unlike
@_specialize,@differentiablemay also be declared onAbstractStorageDecldeclarations(subscripts and variables).
Upstreams #27451.
Progress towards TF-828: upstream
@differentiableattribute type-checking.@differentiableattribute type-checking mega-patch: #29091Tests exist on
tensorflowbranch and will be upstreamed later.Currently, not enough code has been upstreamed for meaningful testing.