ModuleInterface: lock .swiftinterface while generating module cache #29101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
This ensures only one process is generating module cache from an interface file so that we don't blow up memory usage when multiple processes are doing the same. The locking mechanism is similar to that of Clang's. A better approach is that the build system takes care of the module building step as a formal dependency. rdar://52839445
nkcsgexi
force-pushed
the
lock-interface-gen-module
branch
from
53df79e to
8dda019
Compare
|
@swift-ci please smoke test |
|
The issue I saw when I was testing this same thing was that |
|
hmm, if one iteration isn't sufficient then the process should enter another cycle of waiting the lock. Does 40 sec limit really matter in this case? |
|
Wouldn’t that start a new build? |
|
That would start acquiring another lock (notice there is a while(1) loop outside of the lock). But your point makes me think probably we should keep waiting if timed-out rather than removing the lock file unconditionally, which means opening the flood gate and suddenly all processes start to rebuilding. |
|
Seeing test failure which might be related to this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures only one process is generating module cache from an interface
file so that we don't blow up memory usage when multiple processes are
doing the same. The locking mechanism is similar to that of Clang's.
A better approach is that the build system takes care of the module building
step as a formal dependency.
rdar://52839445