Skip to content

[test][android] Mark inherits-superclass-initializers-client as executable. #29235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

drodriguez
Copy link
Contributor

The test uses %target-run, which requires executing code. Android CI
cannot execute code because no device is attached. Marking the test as
executable skip it in the Android CI machines.

This is a NFC for almost every other platform except Android.

/cc @harlanhaskins

…table.

The test uses %target-run, which requires executing code. Android CI
cannot execute code because no device is attached. Marking the test as
executable skip it in the Android CI machines.
@drodriguez
Copy link
Contributor Author

@swift-ci please test

@harlanhaskins
Copy link
Contributor

Thanks! Apologies for missing this.

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - eb90ff2

@drodriguez
Copy link
Contributor Author

That Linux failure seems to be related to #29101, which was reverted in #29114, and then reapplied in #29123. But the error is different. I will let the macOS test finish before restarting or anything.

@drodriguez
Copy link
Contributor Author

@swift-ci please test Linux platform

@drodriguez drodriguez merged commit a34956b into swiftlang:master Jan 16, 2020
@drodriguez drodriguez deleted the executable-inherits-superclass-initializers-client branch January 16, 2020 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants