Skip to content

Re-apply "ModuleInterface: lock .swiftinterface while generating module cache" #29123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2020
Merged

Re-apply "ModuleInterface: lock .swiftinterface while generating module cache" #29123

merged 1 commit into from
Jan 10, 2020

Conversation

nkcsgexi
Copy link
Contributor

No description provided.

@nkcsgexi
Copy link
Contributor Author

@swift-ci please test

@nkcsgexi nkcsgexi requested a review from shahmishal January 10, 2020 18:23
@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 96bfc692d3c7446234f0fdc72620866fe0f25449

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96bfc692d3c7446234f0fdc72620866fe0f25449

CodaFi
CodaFi reviewed Jan 10, 2020
View reviewed changes
lib/Frontend/ModuleInterfaceBuilder.cpp
// Someone else is responsible for building the module. Wait for them to
// finish.
switch (Locked.waitForUnlock()) {
case llvm::LockFileManager::Res_Success: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still going to cause stampedes. A lot of the interfaces take longer than the default timeout interval of 40 seconds to generate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could change llvm side to take a parameter for waitForUnlock() to indicate the maximum waiting time. It doesn't fundamentally invalidate this approach.

@nkcsgexi
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96bfc692d3c7446234f0fdc72620866fe0f25449

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 96bfc692d3c7446234f0fdc72620866fe0f25449

@nkcsgexi nkcsgexi merged commit 0f96a5e into swiftlang:master Jan 10, 2020
@drodriguez drodriguez mentioned this pull request Jan 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodaFi CodaFi CodaFi left review comments

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkcsgexi @swift-ci @CodaFi