[parse-sil] Refactor huge per op code parsing switch into its own method. #29169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hod. Done using Xcode's refactoring engine! Should be NFC. I am going to turn this method into a visitor on the op code. NOTE: Xcode's refactoring engine messd with the whitespace, so I also ran this through git-clang-format.
|
@swift-ci test |
atrick
approved these changes
Jan 13, 2020
|
Build failed |
|
Linux failure was the infamous dispatch overlay thing. |
|
@swift-ci test linux platform |
|
Build failed |
|
@swift-ci test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done using Xcode's refactoring engine! Should be NFC.
I am going to turn this method into a visitor on the op code.
NOTE: Xcode's refactoring engine messd with the whitespace, so I also ran this
through git-clang-format.
Just done while I was bored last night. We have talked about doing this a long time since it is impossible to separate the rest of the functionality from the method from the huge switch.