tests: fix accidental not env usage
#29198
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manually expand out the few places where we had a `not ...` substitution where the substituted value was invoking `env` to alter the environment. This pattern is not portable and causes problems when using the integrated shell, such as on Windows. This was identified during the LLVM update. This additionally corrects the use of `not` to indicate that it is expecting a crashing failure. This was resulting in the Windows tests failing as `not` was not expecting a crashing failure.
|
@swift-ci please test macOS platform |
|
CC: @gottesmm |
|
Build failed |
|
|
@swift-ci please test macOS platform |
|
Build failed |
|
@swift-ci please test macOS platform |
|
Build failed |
|
@CodaFi was looking into resolving this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manually expand out the few places where we had a
not ...substitutionwhere the substituted value was invoking
envto alter the environment.This pattern is not portable and causes problems when using the
integrated shell, such as on Windows. This was identified during the
LLVM update.
This additionally corrects the use of
notto indicate that it isexpecting a crashing failure. This was resulting in the Windows tests
failing as
notwas not expecting a crashing failure.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.