Specialize a test for Windows #29794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An unfortunate workaround for rdar://59397376 Resolves rdar://59318361
|
@swift-ci smoke test |
|
@swift-ci test windows platform |
CodaFi
commented
Feb 12, 2020
| @@ -0,0 +1,13 @@ | |||
| # This test is intentionally specialized on windows becauase not --crash behaves | |||
| # differently there. The exit code from the crashing frontend invocations is | |||
| # mapped to `-21` there, which lit's `not` along does not remap correctly. | |||
There was a problem hiding this comment.
Heh, I know english.
Will correct this in a follow-up.
|
@swift-ci test windows platform |
|
@swift-ci smoke test macOS platform |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unfortunate workaround for rdar://59397376
Resolves rdar://59318361
Supersedes the not-env work in #29198