Skip to content

Specialize a test for Windows #29794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Specialize a test for Windows #29794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions test/ModuleInterface/swift_build_sdk_interfaces/compiler-crash-windows.test-sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# This test is intentionally specialized on windows becauase not --crash behaves
# differently there. The exit code from the crashing frontend invocations is
# mapped to `-21` there, which lit's `not` along does not remap correctly.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I know english.

Will correct this in a follow-up.

# See rdar://59397376
REQUIRES: OS=windows-msvc

RUN: env SWIFT_EXEC=%swiftc_driver_plain not --crash %{python} %utils/swift_build_sdk_interfaces.py %mcp_opt -sdk %S/Inputs/mock-sdk/ -o %t/output -debug-crash-compiler 2>&1 | %FileCheck %s

CHECK: Program arguments:
CHECK-SAME: -debug-crash-immediately
CHECK-SAME: {{.+}}.swiftinterface

REQUIRES: asserts
3 changes: 2 additions & 1 deletion test/ModuleInterface/swift_build_sdk_interfaces/compiler-crash.test-sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
REQUIRES: rdar59318361
# For its Windows counterpart, see compiler-crash-windows.test-sh
UNSUPPORTED: windows

RUN: not %swift_build_sdk_interfaces -sdk %S/Inputs/mock-sdk/ -o %t/output -debug-crash-compiler 2>&1 | %FileCheck %s

Expand Down