Skip to content

[Build System: build-script] Version module. #29247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2020
Merged

[Build System: build-script] Version module. #29247

merged 1 commit into from
Jan 18, 2020

Conversation

Rostepher
Copy link
Contributor

Add a new versions module to build_swift which provides the Version class. The Version class acts very similarly to distutils.version.LooseVersion, but with some more flexibility around character group boundaries.

Builds on changes in #29244

@Rostepher Rostepher requested review from compnerd and edymtt January 16, 2020 07:47
compnerd
compnerd approved these changes Jan 16, 2020
View reviewed changes
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the new Version type too thoroughly, but at a quick glance, seems fine.

@Rostepher Rostepher force-pushed the version-module branch 3 times, most recently from 5a45c98 to 2d4c386 Compare January 17, 2020 07:29
@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher Rostepher changed the title [Build System: build-script] Version module [Build System: build-script] Version module. Jan 17, 2020
@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

[Build System: build-script] Add a new versions module to build_swift…
67d6b10 
… which provides the Version class.

Version acts very similarly to distutils.version.LooseVersion, but with some more flexibility around character group boundries.
@Rostepher
Copy link
Contributor Author

@swift-ci please smoke test

@Rostepher Rostepher merged commit c9bf062 into swiftlang:master Jan 18, 2020
@Rostepher Rostepher deleted the version-module branch January 18, 2020 23:16
@beccadax beccadax mentioned this pull request Jan 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@edymtt edymtt Awaiting requested review from edymtt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rostepher @compnerd