Skip to content

Fix build-script --dump-config #29337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Conversation

beccadax
Copy link
Contributor

The Version object, introduced in #29247, used __slots__ instead of __dict__, so it was not serializable. Update JSONDumper to stringify objects if vars() won’t work.

This change does not update any tests because build-script does not currently have a way to write full-script integration tests.

@beccadax beccadax requested a review from Rostepher January 21, 2020 19:53
@beccadax
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 8c19614f502d002028f65cb388084af32903fbb7

The Version object used __slots__ instead of __dict__, so it was not serializable. Update JSONDumper to stringify objects if vars() won’t work.

This change does not update any tests because build-script does not currently have a way to write full-script integration tests.
@beccadax
Copy link
Contributor Author

@swift-ci test and merge

@Rostepher
Copy link
Contributor

@swift-ci please test and merge

@swift-ci swift-ci merged commit c40b298 into swiftlang:master Jan 22, 2020
@beccadax beccadax deleted the dump-fire branch January 22, 2020 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants