Disable failing SourceKit tests #29503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would seem that despite getting a green checkmark from CI, #29347 broke `tensorflow` HEAD. There are now a few SourceKit tests which fail only on macOS. In this PR, I'm disabling the failing tests pending a full-fledged investigation.
|
@swift-ci please clean test tensorflow |
dan-zheng
approved these changes
Jan 28, 2020
|
Thanks for checking if I had accidentally triggered some other failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would seem that despite getting a green checkmark from CI, #29347 broke
tensorflowHEAD. There are now a few SourceKit tests which fail only on macOS. In this PR, I'm disabling the failing tests pending a full-fledged investigation.